Merge branch 'ab_Fix_AtomicFileWrite' into 'devbranch'

Fix: File is being used by another process error on atomic write.

See merge request !131

filemdl/filemdl.go

@@ -644,7 +644,13 @@ func writeFileSafely(filePath string, data []byte, perm os.FileMode) error {
 		return err
 	}
 
-	defer tmpFile.Close()
+	closeTempFile := true
+
+	defer func() {
+		if closeTempFile {
+			tmpFile.Close()
+		}
+	}()
 
 	n, err := tmpFile.Write(data)
 	if err != nil {
@@ -671,7 +677,13 @@ func writeFileSafely(filePath string, data []byte, perm os.FileMode) error {
 			return errormdl.Wrap("can't set filemode on tempfile: " + tmpFileName + ", error: " + err.Error())
 		}
 	}
-	loggermdl.LogError(tmpFileName)
+	// loggermdl.LogError(tmpFileName)
+	// set closeTempFile to false and close the tempFile. The file will be opened in AtomicReplaceFile function.
+	// If we don't close the file here, we will get "file is being used by another process" error
+
+	closeTempFile = false
+	tmpFile.Close()
+
 	if err := AtomicReplaceFile(tmpFileName, filePath); err != nil {
 		loggermdl.LogError("Atomic replace failed - ", err)
 		return errormdl.Wrap("cannot replace " + filePath + " with " + tmpFileName)